Skip to content

docs: fix broken skill reference in mcp-config.md (#933) - #954

Merged
tamirdresher merged 1 commit into
devfrom
squad/933-fix-broken-skill-ref
Apr 12, 2026
Merged

tamirdresher merged 1 commit into
devfrom
squad/933-fix-broken-skill-ref

Conversation

@diberry

@diberry diberry commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

Closes #933

Removes references to the non-existent .squad/skills/mcp-tool-discovery/SKILL.md
across all template and configuration files, restoring user trust in our
documentation.

Changes:

  • Removed broken skill path from mcp-config.md files across .squad/, .squad-templates/,
    and packages/ directories
  • Cleaned up agent configuration files
  • Minimal fix: only removed the broken reference, no restructuring

@diberry
diberry force-pushed the squad/933-fix-broken-skill-ref branch from 42c0e0e to 2d785dc Compare April 10, 2026 14:52
@diberry
diberry marked this pull request as ready for review April 10, 2026 14:59
Copilot AI review requested due to automatic review settings April 10, 2026 14:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes a broken documentation reference to a non-existent MCP skill file from the Squad agent templates and MCP configuration templates.

Changes:

  • Removed the .squad/skills/mcp-tool-discovery/SKILL.md reference from squad.agent.md templates.
  • Removed the same broken reference from mcp-config.md templates across templates/ and packages/*/templates/.
  • Updated the .github/agents/squad.agent.md copy to match the new template text.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
templates/squad.agent.md.template Drops the broken MCP skill link from the “MCP Integration” callout.
templates/mcp-config.md Removes the broken MCP skill reference from the config doc header section.
packages/squad-sdk/templates/squad.agent.md.template Mirrors the agent template change for the SDK template set.
packages/squad-sdk/templates/mcp-config.md Mirrors the config doc change for the SDK template set.
packages/squad-cli/templates/squad.agent.md.template Mirrors the agent template change for the CLI template set.
packages/squad-cli/templates/mcp-config.md Mirrors the config doc change for the CLI template set.
.squad-templates/squad.agent.md Updates the canonical agent template to remove the broken reference.
.squad-templates/mcp-config.md Updates the canonical MCP config template to remove the broken reference.
.github/agents/squad.agent.md Updates the GitHub agent doc copy to remove the broken reference.

Comment thread templates/mcp-config.md Resolved
Comment thread .squad-templates/squad.agent.md Resolved
Comment thread .squad-templates/mcp-config.md Resolved
Removes references to non-existent .squad/skills/mcp-tool-discovery/SKILL.md
across all template and configuration files.

Closes #933

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@diberry
diberry force-pushed the squad/933-fix-broken-skill-ref branch from 2d785dc to 7682c7b Compare April 10, 2026 16:02
@diberry

diberry commented Apr 10, 2026

Copy link
Copy Markdown
Contributor Author

✅ CI passes on fork — diberry/squad PR #146 (all checks green). Copilot review feedback addressed. Ready for human review.

@tamirdresher
tamirdresher merged commit bd919af into dev Apr 12, 2026
@tamirdresher
tamirdresher deleted the squad/933-fix-broken-skill-ref branch April 12, 2026 10:34
tamirdresher pushed a commit that referenced this pull request Apr 21, 2026
Removes references to non-existent .squad/skills/mcp-tool-discovery/SKILL.md
across all template and configuration files.

Closes #933

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: fix broken skill reference in mcp-config.md (#897)

3 participants